From 3ec2a2902caaf3e70deea650425339299af5d821 Mon Sep 17 00:00:00 2001
From: zlg <zlg@zlg.space>
Date: Thu, 18 Oct 2018 16:36:39 -0700
Subject: Catch when an invalid list filter is passed

Before, vgstash.DB.list_games() would default to 'allgames' and silently
hide it when a filter wasn't found. This commit ensures that the vgstash
package and CLI both indicate when an invalid filter is passed to them:

* vgstash.DB.list_games() will return False on a failure to match;
* vgstash_cli uses Click's Choice object to enforce the constraint
---
 tests/test_vgstash_cli.py | 7 +++++++
 1 file changed, 7 insertions(+)

(limited to 'tests/test_vgstash_cli.py')

diff --git a/tests/test_vgstash_cli.py b/tests/test_vgstash_cli.py
index 02f0d81..f34f2d1 100644
--- a/tests/test_vgstash_cli.py
+++ b/tests/test_vgstash_cli.py
@@ -99,6 +99,13 @@ def test_list_filter():
         'The Legend of Zelda|NES|2|2|\n',
     ))
 
+def test_list_filter_invalid():
+    runner = CliRunner()
+    result = runner.invoke(vgstash_cli.cli, ['list', '-r', 'derp'])
+    if verbose:
+        print(result.output)
+    assert result.exit_code != 0
+
 
 def test_list_pretty():
     runner = CliRunner()
-- 
cgit v1.2.3-54-g00ecf

lanks.c?showmsg=1&amp;follow=1'>log</a><a href='/knr/tree/1-18_strip-blanks.c'>tree</a><a href='/knr/commit/1-18_strip-blanks.c?follow=1'>commit</a><a href='/knr/diff/1-18_strip-blanks.c?follow=1'>diff</a></td><td class='form'><form class='right' method='get' action='/knr/log/1-18_strip-blanks.c'>
<input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/knr/log/?showmsg=1&amp;follow=1'>root</a>/<a href='/knr/log/1-18_strip-blanks.c?showmsg=1&amp;follow=1'>1-18_strip-blanks.c</a> (<a href='/knr/log/1-18_strip-blanks.c?showmsg=1'>unfollow</a>)</div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/knr/log/1-18_strip-blanks.c?follow=1'>Collapse</a>)</th><th class='left'>Author</th><th class='left'>Files</th><th class='left'>Lines</th></tr>
<tr class='logheader'><td><span title='2022-01-23 23:26:33 -0800'>2022-01-23</span></td><td class='logsubject'><a href='/knr/commit/README.mdown?id=13a2623393c3223ff32abc9e7d5979daf7391301&amp;follow=1'>README.mdown: Add some extra bits about the project</a></td><td>zlg</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+8</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='5' class='logmsg'>
</td></tr>