diff options
| author | zlg <zlg@zlg.space> | 2018-10-18 16:36:39 -0700 |
|---|---|---|
| committer | zlg <zlg@zlg.space> | 2018-10-18 16:36:39 -0700 |
| commit | 3ec2a2902caaf3e70deea650425339299af5d821 (patch) | |
| tree | 158d1c8baf932bd05af7f5ac7878243358beb240 /tests/test_vgstash.py | |
| parent | cli: Add zero-game import/export messages (diff) | |
| download | vgstash-3ec2a2902caaf3e70deea650425339299af5d821.tar.gz vgstash-3ec2a2902caaf3e70deea650425339299af5d821.tar.bz2 vgstash-3ec2a2902caaf3e70deea650425339299af5d821.tar.xz vgstash-3ec2a2902caaf3e70deea650425339299af5d821.zip | |
Catch when an invalid list filter is passed
Before, vgstash.DB.list_games() would default to 'allgames' and silently
hide it when a filter wasn't found. This commit ensures that the vgstash
package and CLI both indicate when an invalid filter is passed to them:
* vgstash.DB.list_games() will return False on a failure to match;
* vgstash_cli uses Click's Choice object to enforce the constraint
Diffstat (limited to 'tests/test_vgstash.py')
| -rw-r--r-- | tests/test_vgstash.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/test_vgstash.py b/tests/test_vgstash.py index 74f3c43..43cd639 100644 --- a/tests/test_vgstash.py +++ b/tests/test_vgstash.py @@ -129,6 +129,10 @@ def test_db_list_games(vgstash_db): assert isinstance(res, list) assert isinstance(res[0], sqlite3.Row) +def test_db_list_games_not_found(vgstash_db): + res = vgstash_db.list_games("derp") + assert res == False + def test_db_add_filter(vgstash_db): assert vgstash_db.add_filter("db_add_filter", "SELECT * FROM games WHERE system = 'system2'") assert vgstash_db.has_filter("db_add_filter") |